His first poetry book was published in 1956 “Aag Main Phool” which received the Presidential Award in 1958. Later, he started his successful career as a lyricist, receiving Nigar Awards for the films Aanchal and Daaman in 1962 and 1963 respectively. In 1966, Shair produced and directed “Lori” (Lullaby) starring Muhammad Ali, Zeba, Santosh Kumar. The movie completed its Golden Jubilee by running for 52 weeks in Karachi. Shair wrote few of the evergreen songs ever written in the cinema of Pakistan. Some of the songs include Na Chura Sakogay Daaman, Jaag Utha Hai Sara Watan, Khudawanda Yeh Kaisi Aag, Jab Raat Dhali, Har Qadam Per Nit Naye Sanchay Main Dhal Jatay Hain Log, Tujh Ko Maloom Naheen and many others.